Remove tls handling override when no pinner provided #775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When no pinner was provided, it is expected that framework will use whatever iOS will provide. But instead - it will allow ALL connections, bypassing any verification. This is breaking change, but most clients of the library probably never had to do that. Client can still allow selfSigned certs with FoundationSecurityError.allowSelfSigned.
|
The problem I encountered in the first place is: I couldn't understand how to fix that particular issue, so looked for a workarounds. |
myeyesareblind
changed the title
|
As part of ongoing research, we found that the current behavior of Starscream does not use the normal iOS certificate verification logic if pinners are not provided. As a result, the default configuration is vulnerable to MITM attacks using, for example, valid TLS certificates for the wrong domain. This PR fixes the issue by not overriding the verifier if a pinner is not provided. Could you please take a look at this PR? We believe it constitutes a vulnerability. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When no pinner was provided, it is expected that framework will use
whatever iOS will provide. But instead - it will allow ALL
connections, bypassing any verification.
This is breaking change, but most clients of the library probably
never had to do that.
Client can still allow selfSigned certs with FoundationSecurityError.allowSelfSigned.