Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment improvements #132

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Comment improvements #132

wants to merge 2 commits into from

Conversation

dambem
Copy link
Owner

@dambem dambem commented Aug 8, 2020

just a PR to add some more comments and hopefully make some of the functions more clear!

Copy link
Collaborator

@Megan-Wright Megan-Wright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of tiny little things but otherwise looks good 👍

/**
* Human display, append HTML with showing how many people would lose they're lives due to pollution
* @param {int} people - Amount of people
* @param {int} infected - Amount of people
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amount of people infected?

@@ -110,7 +119,13 @@ function fractionalreducer(numerator, denominator) {
gcd = gcd(numerator, denominator)
return [numerator/gcd, denominator/gcd]
}

/**
* Human display, append HTML with showing how many people would lose they're lives due to pollution
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*their lives

@dambem
Copy link
Owner Author

dambem commented Aug 9, 2020

Once my other PR is through i'll update that fully and get the changes sorted!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants