-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comment improvements #132
base: master
Are you sure you want to change the base?
Comment improvements #132
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of tiny little things but otherwise looks good 👍
/** | ||
* Human display, append HTML with showing how many people would lose they're lives due to pollution | ||
* @param {int} people - Amount of people | ||
* @param {int} infected - Amount of people |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amount of people infected?
@@ -110,7 +119,13 @@ function fractionalreducer(numerator, denominator) { | |||
gcd = gcd(numerator, denominator) | |||
return [numerator/gcd, denominator/gcd] | |||
} | |||
|
|||
/** | |||
* Human display, append HTML with showing how many people would lose they're lives due to pollution |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
*their lives
Once my other PR is through i'll update that fully and get the changes sorted! |
just a PR to add some more comments and hopefully make some of the functions more clear!