Skip to content
This repository has been archived by the owner on Dec 5, 2019. It is now read-only.

Commit

Permalink
Need to reference Microsoft.CSharp directly for build to pass.
Browse files Browse the repository at this point in the history
  • Loading branch information
damianh committed Jan 4, 2019
1 parent 61dd804 commit bc09b13
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions src/LibLog.Example.Library/LibLog.Example.Library.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,6 @@
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
</PackageReference>
<PackageReference Include="Microsoft.CSharp" Version="4.5.0" />
</ItemGroup>
</Project>
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,6 @@
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
</PackageReference>
<PackageReference Include="Microsoft.CSharp" Version="4.5.0" />
</ItemGroup>
</Project>

2 comments on commit bc09b13

@jesperll
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once you publish a new nuget package without dynamics ( #200 ) and upgrade to use it here you'll be able to remove this again and the examples will build fine.

@damianh
Copy link
Owner Author

@damianh damianh commented on bc09b13 Jan 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep! This is a bit of a circular reference - I wanted the examples to reference the package and not the project. Will fix this when update shipped. 👍

Please sign in to comment.