Parameterise "StatusCounter" tests (#973) #979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #979 +/- ##
============================================
- Coverage 97.94% 97.93% -0.01%
Complexity 557 557
============================================
Files 54 54
Lines 1166 1164 -2
Branches 106 106
============================================
- Hits 1142 1140 -2
Misses 9 9
Partials 15 15
Continue to review full report at Codecov.
|
| @@ -76,7 +73,7 @@ public int getValueFor(Status status) { | |||
| * @return sum of all occurrences for all statuses | |||
| */ | |||
| public int size() { | |||
| return size; | |||
| return counter.values().stream().mapToInt(Integer::valueOf).sum(); | |||
There was a problem hiding this comment.
nice but rather not very efficient if size() is invoked often and report is big
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.