Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support encoding of byte arrays #14

Merged
merged 1 commit into from
Jul 8, 2023
Merged

Conversation

aruthane
Copy link
Contributor

When serializing a byte[] value, it would call byte[].toString() rather than writing out the bytes in the array. This patch will check if a value is a byte[] and handle it accordingly.

@codecov-commenter
Copy link

codecov-commenter commented Jul 1, 2023

Codecov Report

Merging #14 (43be1b3) into master (85050a6) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff              @@
##             master      #14      +/-   ##
============================================
+ Coverage     98.59%   98.61%   +0.02%     
- Complexity       96       98       +2     
============================================
  Files             7        7              
  Lines           213      217       +4     
  Branches         30       31       +1     
============================================
+ Hits            210      214       +4     
  Partials          3        3              
Impacted Files Coverage Δ
...java/com/dampcake/bencode/BencodeOutputStream.java 98.55% <100.00%> (+0.08%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dampcake dampcake merged commit 8823b21 into dampcake:master Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants