Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Damoose: Highlighter #2375

Closed
Tracked by #2238
jb55 opened this issue Aug 9, 2024 · 6 comments
Closed
Tracked by #2238

Damoose: Highlighter #2375

jb55 opened this issue Aug 9, 2024 · 6 comments
Assignees
@danieldaquino
Labels
damoose The damus safari extension highlight
Milestone
1.10: push notifi...

Comments

@jb55
Copy link
Collaborator

jb55 commented Aug 9, 2024

No description provided.

@jb55 jb55 added the damoose The damus safari extension label Aug 9, 2024
@jb55 jb55 mentioned this issue Aug 9, 2024
Open
2 tasks
@alltheseas
Copy link
Collaborator

Related; highlights in long form notes #822

@danieldaquino danieldaquino moved this to In Progress in Damus Roadmap 🛣️ Aug 10, 2024
@danieldaquino danieldaquino self-assigned this Aug 10, 2024
@alltheseas alltheseas mentioned this issue Aug 12, 2024
Open
@danieldaquino
Copy link
Contributor

@jb55 @alltheseas does the current highlighter extension meet the acceptance criteria for this ticket?

@alltheseas
Copy link
Collaborator

I can create a highlight in safari, see the highlight, click
on the link / website url.

One nit, which I can add as a separate add-on ticket is to explore adding something after "highlighted ______" in the case of a safari highlight.

See comparison below with highlight made directly on nostr

image

@alltheseas
Copy link
Collaborator

alltheseas commented Sep 6, 2024 •
edited
Loading

does the current highlighter extension meet the acceptance criteria for this ticket?

LGTM!

@alltheseas
Copy link
Collaborator

#2428

@danieldaquino
Copy link
Contributor

does the current highlighter extension meet the acceptance criteria for this ticket?

LGTM!

@jb55 closing this ticket as we have a highlighter implemented. Please feel free to reopen if you disagree. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danieldaquino danieldaquino

Labels
damoose The damus safari extension highlight
Projects
Damus Roadmap 🛣️
Archived in project
Milestone
1.10: push notifications + quality of...
Development

No branches or pull requests
3 participants
@jb55 @danieldaquino @alltheseas