Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial nostrdb integration #1393

Merged
merged 1 commit into from
Aug 3, 2023
Merged

Initial nostrdb integration #1393

merged 1 commit into from
Aug 3, 2023

Conversation

jb55
Copy link
Collaborator

@jb55 jb55 commented Jul 28, 2023

This is a rewrite of the codebase. There was no reasonable way to break this into smaller commits, so here it is.

  • Switch to nostrdb's NdbNote type instead of NostrEvents
  • Much improved typing, Pubkeys are now Pubkeys (raw data) instead of String

This prepares the codebase for the switch over to memory-mapped note data which will live inside lmdb.

@jb55
Copy link
Collaborator Author

jb55 commented Jul 31, 2023

these commits are too big. since I'm seeing a few bugs on this branch I am going to start making the commits more granular so I can bisect issues

@jb55 jb55 force-pushed the ndb branch 6 times, most recently from 6d91047 to 9cb4249 Compare August 3, 2023 20:20
This is a refactor of the codebase to use a more memory-efficient
representation of notes. It should also be much faster at decoding since
we're using a custom C json parser now.

Changelog-Changed: Improved memory usage and performance when processing events
@jb55 jb55 merged commit cebd1f4 into master Aug 3, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant