Add bech32_{nprofile,nevent,naddr}::relays_to_strings #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksedgwic
force-pushed
the
2025-01-relays_to_strings
branch
from
a3c6b75 to
ce089df
Compare
ksedgwic
force-pushed
the
2025-01-relays_to_strings
branch
from
ce089df to
6383c8d
Compare
|
adding this to my list today! |
jb55
requested changes
Feb 4, 2025
src/block.rs
Outdated
Comment on lines
75
to
79
| pub fn relays_to_strings(&self) -> Vec<String> { | ||
| self.relays.relays[0..(self.relays.num_relays as usize)] | ||
| .iter() | ||
| .map(|block| block.as_str().to_string()) | ||
| .collect() | ||
| } |
There was a problem hiding this comment.
this is not correct, no nostrdb api should require copying data or allocating data on the heap (vec). we probably want to make an iterator for this
ksedgwic
force-pushed
the
2025-01-relays_to_strings
branch
from
6383c8d to
ad3b345
Compare
|
Fixed |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This accessor safely fetches the optional relay hints from the three mention types that have them