Add NIP-22 kind 1111 comment support. signed off by elsat -npub1zafcm… #93
+236
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s4xya5ap9zr7xxr0jlrtrattwlesytn2s42030lzu0dwlzqpd26k5
|
@jb55 👀 |
|
d571706 should be in line with nevernesting requirement |
|
this changes the nip10 parsing code which I copied from nostrdb-rs. this repo doesn't contain the tests from there, so before we can change the reply parsing code we'll need to port the nip10 test coverage from rust first. they are found in src/util/nip10.rs in nostrdb-rs |
|
6a23012 👀 |
jb55
requested changes
Nov 4, 2025
| return 0; | ||
| } | ||
|
|
||
| void ndb_note_get_reply(struct ndb_note *note, struct ndb_note_reply *reply) |
There was a problem hiding this comment.
not sure what the point of these functions are
| direct_replies[0] = *ndb_note_meta_counts_direct_replies(entry); | ||
| printf("\t# direct replies %d\n", direct_replies[0]); | ||
| assert(direct_replies[0] == 83); | ||
| assert(direct_replies[0] == 59); |
There was a problem hiding this comment.
if these are different then that means the reply functions behavior changed/is broken.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s4xya5ap9zr7xxr0jlrtrattwlesytn2s42030lzu0dwlzqpd26k5
Kind 1111 Support
replies, preserving the true root for comment threads while still falling
back to NIP-10 heuristics for classic notes.
1111 comments when rebuilding metadata.
kind classification for comments, letting stats and tooling report them
distinctly.
Testing
(network access needed).
uses deps/secp256k1).