Persist columns #390
Merged
Persist columns #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kernelkind <[email protected]>
we don't yet have logic for handling switching 'deck authors' and this is causing two problems: 1. the column title isn't renamed when the selected account is changed 2. when saving a deck author column to disk and the account is switched beforehand, it switches to the current deck author's column Signed-off-by: kernelkind <[email protected]>
|
need rebase |
|
rebasing this and testing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for writing and loading columns to/from disk. Currently it writes all
Routes except for threads and profiles.The
Column::as_serializable_columnsmethod will probably have to change after #377 but it should be minimal