nostrdb: update to fix profile queries #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
before profile queries were not working at the database level, because there was no note_pubkey or note_pubkey_kind index. Now there is! So profiles should be much faster to query now, and will actually return results. There still appears to be an issue with the profile NotesHolder which is preventing it from updating, via the logic in poll_notes_into_view. The original Timeline version of this function works fine, but it looks like the NotesHolder one is broken. Going to work on refactoring the notes holder next to fix. Signed-off-by: William Casarin <[email protected]>
Fixes: #576 Signed-off-by: William Casarin <[email protected]>
|
Found a simple solution to: everything seems to be working now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before profile queries were not working at the database level, because there was no note_pubkey or note_pubkey_kind index. Now there is! So profiles should be much faster to query now, and will actually return results.
See:
There still appears to be an issue with the profile NotesHolder which is preventing it from updating, via the logic in poll_notes_into_view. The original Timeline version of this function works fine, but it looks like the NotesHolder one is broken:
Going to work on refactoring the notes holder next to fix: