Better Style of Syntax error

[JakobDev]

I think the new looks more like native LUA.

[SquidDev]

You don't need the -1 on the sub calls - Lua will default to the end of the string.

Worth noting that this is also fixed by #163 (/me does puppy eyes at @dan200).

---

Edit: From my testing, return false, err:sub(14) is sufficient to strip the bios.lua element off. Just wondering why you went for the current method rather than this?

[SquidDev]

It's also worth noting that name can be nil, which will result in load erroring. I think a simple err:sub(14) is the best solution here.

[JakobDev]

@SquidDev Have you any example who name is nil, so I can look how to fix this?

[SquidDev]

@Wilma456 You're allowed to use load - something like load("return 1") is legal. Trying to do load("1") crashes with bios.lua:22: attempt to get length of nil.

[JakobDev]

@SquidDev Should be fixed now

[SquidDev]

@Wilma456 Trying load("x") produces nilg"]: '=' expected, which is far from ideal :).

From my testing, return false, err:sub(14) is sufficient to strip the bios.lua element off. Just wondering why you went for the current method rather than this?

[JakobDev]

if err == nil then return should protect from this. Crazy.

[Wojbie]

Why did you put read char limit #330 into this PR?

[JakobDev]

@Wojbie Sorry, this was in the same file and I had not see this. It is now removed.

[Wojbie]

You forgot to push.

[JakobDev]

No. In my Repository it is fixed. https://github.com/Wilma456/ComputerCraft-1/blob/syntaxerr/src/main/resources/assets/computercraft/lua/bios.lua But is not shown here. Maybe it's a Bug of Github. I wait a few hours.

[SquidDev]

if err == nil then return should protect from this. Crazy.

That won't do anything: load should never return a nil error message so that check is redundant. The issue is that your :sub code is invalid.

From my testing, return false, err:sub(14) is sufficient to strip the bios.lua element off. Just wondering why you went for the current method rather than this?

[dan200]

This is very hacky