Fancy rendering of printouts #553
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- When held in first-person, single pages are displayed like a map. - When placed in an item frame, the page is drawn instead of the actual item.
- The current page is always centred when rendering in a GUI, with the turned pages moving from the sides. - Pages are no longer evenly distributed from the centre - they follow an exponential decay curve, so ones further out are closer together (a bit like an open book). - Render pages and books in item frames/in-hand (rather than just single pages). This currently does some very dirty things with z values in order to prevent z-fighting. It would be nice to avoid that, though turning off writing to the z buffer causes issues with the bounding box.
SquidDev
force-pushed
the
feature/fancy-printout
branch
from
bff730d to
50797bb
Compare
ccserver
pushed a commit
to ccserver/ComputerCraft
that referenced
this pull request
Sep 16, 2019
…fancy-printout Fancy rendering of printouts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This renders the contents of printed pages directly when holding them in your hand or displaying them in an item frame. Please note that this implementation isn't currently super optimal as we end up constructing
TextBuffers every frame. I would like to get some feedback on a couple of things before going there.Some things to discuss
Item frame interaction is a little funky, as a lot of the behaviour is hard-coded for maps. The key problems are:
While it would be possible to PR some extensions item frame rendering extensions into Forge for this, I'd rather discuss things here first.
Screenshots
Originally suggested in cc-tweaked/CC-Tweaked#39.