React 19 support #310
Open
React 19 support #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imjordanxd
commented
Dec 14, 2024
| "react": "^19.0.0", | ||
| "react-dom": "^19.0.0", | ||
| "sinon": "^2.1.0", | ||
| "typescript": "^5.7.2" |
There was a problem hiding this comment.
added TS to use the new JSX transform
imjordanxd
commented
Dec 14, 2024
| @@ -36,10 +36,10 @@ | |||
| "prop-types": "^15.5.8" | |||
| }, | |||
| "peerDependencies": { | |||
| "react": "^0.14.9 || ^15.3.0 || ^16.0.0 || ^17.0.0 || ^18.0.0" | |||
| "react": "^0.14.10 || ^15.7.0 || ^16.14.0 || ^17.0.0 || ^18.0.0 || ^19.0.0" | |||
There was a problem hiding this comment.
new JSX transform requires these React versions
imjordanxd
commented
Dec 14, 2024
| @@ -1,24 +1,24 @@ | |||
| { | |||
| "name": "react-infinite-scroller", | |||
| "version": "1.2.6", | |||
| "version": "2.0.0", | |||
There was a problem hiding this comment.
major version bump because of min React peer dep versions
imjordanxd
commented
Dec 14, 2024
package.json
Outdated
| "precommit": "lint-staged" | ||
| }, | ||
| "lint-staged": { | ||
| "*.{js,jsx}": [ | ||
| "node_modules/.bin/eslint --fix --max-warnings 0", | ||
| "src/*.{js,jsx}": [ |
There was a problem hiding this comment.
idk why dist was being linted
imjordanxd
commented
Dec 14, 2024
dist/InfiniteScroll.js
Outdated
There was a problem hiding this comment.
this has been compiled by TS. How can we test this?
imjordanxd
commented
Dec 14, 2024
tsconfig.json
Outdated
There was a problem hiding this comment.
in a next major, prop-types should be removed and TS should be preferred.
imjordanxd
commented
Dec 14, 2024
| "prettier": "^3.4.2", | ||
| "react": "^19.0.0", | ||
| "react-dom": "^19.0.0", | ||
| "ts-jest": "^29.2.5", |
There was a problem hiding this comment.
ts-jest to auto transform code for us - direct babel dep removed
imjordanxd
commented
Dec 14, 2024
| "typescript": "^5.7.2" | ||
| }, | ||
| "engines": { | ||
| "node": "> 18" |
There was a problem hiding this comment.
in maintenance until April 2025
imjordanxd
commented
Dec 14, 2024
| @@ -281,6 +282,6 @@ export default class InfiniteScroll extends Component { | |||
| : childrenArray.push(this.defaultLoader); | |||
| } | |||
| } | |||
| return React.createElement(element, props, childrenArray); | |||
| return <Element {...props}>{childrenArray}</Element>; | |||
imjordanxd
commented
Dec 14, 2024
| "description": "Infinite scroll component for React in ES6", | ||
| "main": "index.js", | ||
| "main": "dist/InfiniteScroll.js", | ||
| "jsnext:main": "src/InfiniteScroll.js", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds support for React 19. I believe everything is covered. Any more testing / peer reviews would be appreciated 🙏