Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance issue on diff with 40k lines #26

Open
jumper047 opened this issue Oct 30, 2023 · 3 comments · May be fixed by #27
Open

Performance issue on diff with 40k lines #26

jumper047 opened this issue Oct 30, 2023 · 3 comments · May be fixed by #27

Comments

@jumper047
Copy link

Title says it all - recently I faced really big diff, like 40k lines changed, and magit buffer became completely unusable. I disabled magit-delta mode, and everything became usable again. Maybe we should have something like magit-delta-max-diff-size parameter?
@dandavison
Copy link
Owner

Hi @jumper047, yes I sympathise with this. I'd be happy to review a PR.

@jumper047 jumper047 linked a pull request Oct 31, 2023 that will close this issue
Open
@jumper047
Copy link
Author

@dandavison done:)

@igorcafe
Copy link

Same problem here.
I think the diff should be lazy loaded when we press tab here, instead of loading automatically as I guess its doing.
Is it possible to do in magit?

Here, I think its loading this retroarch configs that are huge and I'm not even seeing it, and its very laggy
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't apply delta to enormously large buffers jumper047/magit-delta
3 participants
@dandavison @jumper047 @igorcafe