Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't apply delta to enormously large buffers #27

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jumper047
Copy link

Introduces new variable - magit-delta-max-lines, set to 1000 by default. If buffer lines exceeded this value, then default magit highlighting used instead of delta to keep emacs responsive. Regarding default value - 1000 just works for me:). It tooks 2-3 seconds to display diff on Core-I7, so maybe it should be decreased. This MR fixes #26

@dandavison
Copy link
Owner

Thanks! I'm running your commit locally. I might be slightly slow to review and merge due to day job.

@dandavison
Copy link
Owner

If buffer lines exceeded this value, then default magit highlighting used instead of delta

I'm not seeing any color when it disables delta. Do you see the usual magit colors?

@daanturo
Copy link

Do you see the usual magit colors?

I still can see Magit's normal red and green colors, for example this commit: dandavison/delta@79979c2

Screenshot_20240311_223901

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Performance issue on diff with 40k lines
3 participants