Fix PLW2901 for loop variable overwritten by assignment target

dandi · Nov 16, 2023 · 19c5f43 · 19c5f43
1 parent 97ee8c7
commit 19c5f43
Showing 1 changed file with 9 additions and 6 deletions.
diff --git a/dandiapi/api/views/dandiset.py b/dandiapi/api/views/dandiset.py
@@ -398,16 +398,19 @@ def get_user_or_400(username):
             send_ownership_change_emails(dandiset, removed_owners, added_owners)
 
         owners = []
-        for owner in dandiset.owners:
+        for owner_user in dandiset.owners:
             try:
-                owner = SocialAccount.objects.get(user=owner)
-                owner_dict = {'username': owner.extra_data['login']}
-                if 'name' in owner.extra_data:
-                    owner_dict['name'] = owner.extra_data['name']
+                owner_account = SocialAccount.objects.get(user=owner_user)
+                owner_dict = {'username': owner_account.extra_data['login']}
+                if 'name' in owner_account.extra_data:
+                    owner_dict['name'] = owner_account.extra_data['name']
                 owners.append(owner_dict)
             except SocialAccount.DoesNotExist:
                 # Just in case some users aren't using social accounts, have a fallback
                 owners.append(
-                    {'username': owner.username, 'name': f'{owner.first_name} {owner.last_name}'}
+                    {
+                        'username': owner_user.username,
+                        'name': f'{owner_user.first_name} {owner_user.last_name}',
+                    }
                 )
         return Response(owners, status=status.HTTP_200_OK)