Merge pull request #2118 from yarikoptic/enh-no-dockerlogin

Login to docker hub only if credentials were provided
dandi · Dec 19, 2024 · 9bf49de · 9bf49de
2 parents cdeb572 + 1da1253
commit 9bf49de
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/.github/workflows/cli-integration.yml b/.github/workflows/cli-integration.yml
@@ -19,7 +19,11 @@ jobs:
 
       - name: Build Docker image
         run: |
-          docker login -u "$DOCKER_LOGIN" --password-stdin <<<"$DOCKER_TOKEN"
+          if [ -n "$DOCKER_LOGIN$DOCKER_TOKEN" ]; then
+              docker login -u "$DOCKER_LOGIN" --password-stdin <<<"$DOCKER_TOKEN"
+          else
+              echo "Not logging in to docker since no credentials were provided, might hit limits below"
+          fi
           docker build \
             -t dandiarchive/dandiarchive-api \
             -f dev/django-public.Dockerfile \