Switch frontend build process from Webpack to Vite #1725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvandenburgh
changed the title
mvandenburgh
force-pushed
the
vite
branch
5 times, most recently
from
6581c32 to
f2e78c0
Compare
mvandenburgh
changed the title
mvandenburgh
force-pushed
the
vite
branch
5 times, most recently
from
3759711 to
cb639d4
Compare
mvandenburgh
force-pushed
the
vite
branch
3 times, most recently
from
678a896 to
818604b
Compare
|
@mvandenburgh could you remind me of the showstoppers on this one? Are we pinned to a version of one of the libraries for some reason? |
The current blocker is |
mvandenburgh
force-pushed
the
vite
branch
2 times, most recently
from
ea74efe to
16a6fd9
Compare
Options used - ✔ Project name: dandi-archive ✔ Add TypeScript? Yes ✔ Add JSX Support? No ✔ Add Vue Router for Single Page Application development? Yes ✔ Add Pinia for state management? Yes ✔ Add Vitest for Unit Testing? No ✔ Add Cypress for both Unit and End-to-End testing? No ✔ Add ESLint for code quality? Yes ✔ Add Prettier for code formatting? No
Taken from vue.config.js
The `recommended` subset of rules is stricter and our current codebase generates *a lot* of errors with it.
This rule set was implicitly included by the airbnb package we used on the webpack build.
|
I resolved the type checking issues, so I'll coordinate with the rest of the team on Monday to get this reviewed. |
jjnesbitt
requested changes
Dec 4, 2023
jjnesbitt
approved these changes
Dec 7, 2023
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches our frontend build process from vue-cli/Webpack to Vite. Vite is the default tooling for Vue 3, so this will help ease the upgrade to that.
The way I did this PR was
create-vueto bootstrap a new Vue 2 project with Vite in thevite/subdirectoryweb/to the new vite project invite/vite/, converting them to their vite equivalents when needed (for example,vue.config.js=>vite.config.ts.vite/toweb/.Other things to note -
web/test/subdirectory. This didn't seem to be a problem before as both applications used the same eslint version and build tooling (i.e. vue-cli/Webpack); but now, the main app is using vite while the e2e tests use webpack. To resolve this, I just moved the e2e tests into the root of the repo to thee2edirectory.