Design doc for Upload/AssetBlob garbage collection #2068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satra
reviewed
Nov 4, 2024
mvandenburgh
force-pushed
the
asset-blob-upload-gc-doc
branch
2 times, most recently
from
98572f7 to
bd9740f
Compare
mvandenburgh
force-pushed
the
asset-blob-upload-gc-doc
branch
from
bd9740f to
d2f3123
Compare
kabilar
reviewed
Nov 18, 2024
kabilar
reviewed
Nov 18, 2024
There was a problem hiding this comment.
Thank you, @mvandenburgh. I am new to this garbage collection effort, but this design doc looks good from a high-level perspective.
|
Hi @yarikoptic, when you have a chance, can you please review this design doc? Thank you. |
yarikoptic
approved these changes
Nov 20, 2024
Co-authored-by: Yaroslav Halchenko <[email protected]>
waxlamp
requested changes
Dec 12, 2024
Comment on lines
32
to
43
| ### Garbage collection event table | ||
|
|
||
| ```python | ||
| from django.db import models | ||
|
|
||
| class GarbageCollectionEvent(models.Model): | ||
| type = models.CharField(max_length=255) | ||
| created = models.DateTimeField(auto_now_add=True) | ||
| records = models.JSONField() | ||
| ``` | ||
|
|
||
| Note: the `records` field is a JSON serialization of the garbage-collected QuerySet, generated using [Django’s JSON model serializer](https://docs.djangoproject.com/en/5.1/topics/serialization/#serialization-formats-json)). This gives us the minimum information needed to restore a blob. The idea is that this can be reused for garbage collection of `Assets` as well. |
There was a problem hiding this comment.
Can you update this section to reflect the many-to-one design we discussed recently?
There was a problem hiding this comment.
Done. I also updated the implementation PR (#2087) accordingly.
waxlamp
approved these changes
Jan 7, 2025
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This design document proposes a design for garbage collection of
UploadandAssetBlobrecords. A prerequisite to enabling this was the "trailing delete" feature that has landed in production (see doc)A design document for garbage collection of
Assetrecords will follow this one.@yarikoptic @satra PTAL and comment here if you have any objections or general thoughts about the proposed process.