Add API support for Embargoed Zarrs #2069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjnesbitt
force-pushed
the
zarrbargo
branch
2 times, most recently
from
4f1a826 to
d670736
Compare
mvandenburgh
reviewed
Nov 5, 2024
dandiapi/zarr/migrations/0004_zarrarchive_embargoed_delete_embargoedzarrarchive.py
Show resolved
Hide resolved
jjnesbitt
commented
Nov 5, 2024
- Remove EmbargoedZarrArchive model - Remove BaseZarrArchive abstract model - Add ZarrArchive.embargoed column - Fix imports and model usage
mvandenburgh
approved these changes
Nov 13, 2024
2 tasks
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds API support for embargoed zarrs, with the following notable changes:
ZarrArchive,EmbargoedZarrArchive, andBaseZarrArchivehave all been merged into oneZarrArchivemodel.Assetmodel now has anis_embargoedproperty, which will account for both asset blob and zarr embargo status.unembargo_dandisetfunction has been extended to include zarrs.404 Not Foundis returned.This does not address any changes in the GUI, as I'm unsure what exactly that entails. These changes are necessary for embargoed zarr support in any case, and so can be merged before any GUI re-work.