Add ability to release upon workflow dispatch #1589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bits are taken from http://github.com/brechtm/citeproc-py for which bits were taken from somewhere else as well
yarikoptic
added
release
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1589 +/- ##
==========================================
+ Coverage 88.54% 88.64% +0.09%
==========================================
Files 78 78
Lines 10872 10872
==========================================
+ Hits 9627 9637 +10
+ Misses 1245 1235 -10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jwodder
requested changes
Mar 7, 2025
| run: | | ||
| if [ "${{ github.event_name }}" = workflow_dispatch ] | ||
| then opts= | ||
| else opts=--only-publish-with-release-label |
There was a problem hiding this comment.
You also need to remove "onlyPublishWithReleaseLabel": true from .autorc.
There was a problem hiding this comment.
thanks! now this makes more sense to me ;-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bits are taken from http://github.com/brechtm/citeproc-py for which bits were taken from somewhere else as well.
Needed to release and realized that we do not do that upon dispatch yet here