Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Allen Institute OpenScope image #233

Merged
merged 12 commits into from
Feb 19, 2025
Merged

Add Allen Institute OpenScope image #233

merged 12 commits into from
Feb 19, 2025

Conversation

asmacdo
Copy link
Member

@asmacdo asmacdo commented Feb 17, 2025

This PR is intended to replace #208
(and document a process for #223)

@kabilar I've created this as a draft because I suspect that the CI will fail to build. Openscope installs cuda stuff, so probably will run into the same issue as the other GPU builds. #230

@rcpeene is this the correct verification that we have installed correctly?

Screenshot from 2025-02-17 11-37-07

copy existing standard and add openscope image below
ideally, we keep the standard stuff as-is so we can move to a modular build system soon,
with openscope simply FROMing the dandihub standard.

included everything from openscope for transparency, will delete duplicate lines later
ERROR: failed to solve: process "/bin/bash -o pipefail -c apt-get install -y libgl1-mesa-glx" did not complete successfully: exit code: 100
make: *** [Makefile:4: dev] Error 1

See also: https://askubuntu.com/questions/1517352/issues-installing-libgl1-mesa-glx
@asmacdo asmacdo force-pushed the add-openscope-image branch from 9f709eb to 124e3ba Compare February 17, 2025 19:29
@kabilar
Copy link
Member

kabilar commented Feb 19, 2025

@kabilar I've created this as a draft because I suspect that the CI will fail to build. Openscope installs cuda stuff, so probably will run into the same issue as the other GPU builds. #230

Thanks @asmacdo. Hopefully the build will work since the Dockerfile.gpu builds successfully. (Its just the Dockerfile.gpu.matlab that doesn't build.) I will mark as Ready for review to test the build through GitHub Actions. Please let me know when it is ready for review/merge.

@kabilar kabilar marked this pull request as ready for review February 19, 2025 17:29
@asmacdo
Copy link
Member Author

asmacdo commented Feb 19, 2025

@kabilar yeah it did actually work to my surprise, review away :)

@kabilar
Copy link
Member

kabilar commented Feb 19, 2025

Oh actually, the docker-test workflow already ran when you opened the pull request and worked successfully. See run.

@yarikoptic yarikoptic changed the title Add openscope image Add openscope image and add minimal HOWTO to README.md Feb 19, 2025
@kabilar kabilar mentioned this pull request Feb 19, 2025
Co-authored-by: Kabilar Gunalan <[email protected]>
@asmacdo
Copy link
Member Author

asmacdo commented Feb 19, 2025

Moved the docs to dandi/dandi-docs#188

@kabilar kabilar changed the title Add openscope image and add minimal HOWTO to README.md Add Allen Institute OpenScope image Feb 19, 2025
Copy link
Member

@kabilar kabilar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @asmacdo.

@rcpeene, in #208 (comment), you had mentioned wanting to copy over the notebooks from a specific branch of the openscope_databook repository. Feel free to submit a pull request with those updates, or point us to the resources that need to be added to this image.

@kabilar kabilar merged commit 8fc6a16 into main Feb 19, 2025
6 checks passed
@kabilar kabilar mentioned this pull request Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants