Refactor staging bucket to use bucket module #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvandenburgh
approved these changes
Mar 6, 2023
Yeah I'm planning on removing them after they've been applied. |
danlamanna
force-pushed
the
staging-bucket-refactor
branch
from
2bbcc5c to
398673e
Compare
danlamanna
force-pushed
the
staging-bucket-refactor
branch
from
398673e to
823a972
Compare
|
Related #107 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first of a couple PRs I'd like to make around refactoring our S3 infrastructure. I tried to make the plan as minimal as possible by using the
movedblocks but there's still a small portion that couldn't be covered. Namely, the heroku user is getting some permissions through an IAM policy that it used to have through a bucket policy. This refactor gives slightly more permissions than necessary to the heroku user for the ease of refactoring these parts. Once everything uses the common module then we can be judicious about principle of least privilege (ideally this would be data driven via #131).@mvandenburgh I double checked this but since everything we're doing here will eventually be applied to the sponsored bucket I'd like you to take a careful look at it and let me know what you think.