Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add s3:PutObjectTagging permission to sponsored bucket #183

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

jjnesbitt
Copy link
Member

This gives the production heroku user permission for the PutObjectTagging action, from the bucket policy itself. This actually solves the issue that #182 was attempting to solve. That change didn't work because permissions to the production bucket must be added on the bucket policy itself (because the bucket and user reside in two different accounts), and we were only adding that permission to the user itself, not the bucket.

@jjnesbitt jjnesbitt requested a review from danlamanna April 29, 2024 17:01
@jjnesbitt jjnesbitt merged commit f82de1a into master Apr 29, 2024
2 checks passed
@jjnesbitt jjnesbitt deleted the prod-bucket-put-object-tagging branch April 29, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants