Skip to content

Use relative ratio less than epsilon to check zero. #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use relative ratio less than epsilon to check zero. #81

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/vec3.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,9 +165,12 @@ ccd_real_t ccdVec3PointTriDist2(const ccd_vec3_t *P,
r = ccdVec3Dot(&d1, &d2);

d = w * v - r * r;
if (ccdIsZero(d)){
// To avoid division by zero for zero (or near zero) area triangles
s = t = -1.;
if (ccdIsZero(d / (w * v))){
// To avoid division by zero for zero (or near zero) area triangles. The
// numerical error can be caused by subtracting two large numbers, and the
// ratio (d/ (w * v) in this case) between their difference to one of the
// large number is smaller than numerical epsilon.
s = t = -1.;
}else{
s = (q * r - w * p) / d;
t = (-s * r - q) / w;
Expand Down