Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android support #635

Merged
merged 2 commits into from
Jan 6, 2025
Merged

Android support #635

merged 2 commits into from
Jan 6, 2025

Conversation

marcprux
Copy link
Contributor

@marcprux marcprux commented Jan 6, 2025

This PR enables Danger to be compiled for Android by fixing the single Glibc import to be conditional.

f-meloni
f-meloni approved these changes Jan 6, 2025
View reviewed changes
Copy link
Member

@f-meloni f-meloni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Can you please update the CHANGELOG?

@marcprux
Copy link
Contributor Author

marcprux commented Jan 6, 2025

Thank you! Can you please update the CHANGELOG?

Done in d2d62bd

@f-meloni f-meloni merged commit e035543 into danger:master Jan 6, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@f-meloni f-meloni f-meloni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcprux @f-meloni