Updated mass defintions to match pyHalo #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Now when loading a galacticus file concentrations are used by default to calculate virial radius using the new concentration parameter in the output. This allows the definition of virial radius to match that used in pyHalo. Additionally, refactor DMFromGalacticus to allow for modifying which parameters get passed when creating TNFWFromParams object. This should allow for more flexible behavior in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated parameter files / hdf5 files. Now contain "massHaloEnclosedCurrent" and "concentration" parameters which give definitions for the infall mass and concentration that should match the definitions used in pyHalo.
Additionally, updated TNFW_example.xml to credit author.