Skip to content

Commit

Permalink
chore(perf): Remove # FIXME(s) that had no effect
Browse files Browse the repository at this point in the history
  • Loading branch information
dangotbanned committed Sep 1, 2024
1 parent a419ede commit 4a7cc4e
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 3 deletions.
1 change: 0 additions & 1 deletion altair/utils/core.py
Original file line number Diff line number Diff line change
Expand Up @@ -830,7 +830,6 @@ def from_channels(cls, channels: ModuleType, /) -> _ChannelCache:
@classmethod
def from_cache(cls) -> _ChannelCache:
global _CHANNEL_CACHE
# FIXME: Hot try/except
try:
cached = _CHANNEL_CACHE
except NameError:
Expand Down
2 changes: 0 additions & 2 deletions altair/vegalite/v5/api.py
Original file line number Diff line number Diff line change
Expand Up @@ -1803,7 +1803,6 @@ def to_dict( # noqa: C901
copy = _top_schema_base(self).copy(deep=False)
original_data = getattr(copy, "data", Undefined)
if not utils.is_undefined(original_data):
# FIXME: Hot try/except
try:
data = _to_eager_narwhals_dataframe(original_data)
except TypeError:
Expand Down Expand Up @@ -3419,7 +3418,6 @@ def _repr_mimebundle_(self, *args, **kwds) -> MimeBundleType | None: # type:ign
"""Return a MIME bundle for display in Jupyter frontends."""
# Catch errors explicitly to get around issues in Jupyter frontend
# see https://github.com/ipython/ipython/issues/11038
# FIXME: Hot try/except
try:
dct = self.to_dict(context={"pre_transform": False})
except Exception:
Expand Down

0 comments on commit 4a7cc4e

Please sign in to comment.