ci: fix PT001 rule inversion conflict

See astral-sh/ruff#12106 I've fixed to the new behaviour and disabled the rule
dangotbanned · Jul 6, 2024 · f95be1a · f95be1a
1 parent f33a9cd
commit f95be1a
Show file tree

Hide file tree

Showing 9 changed files with 11 additions and 10 deletions.
diff --git a/pyproject.toml b/pyproject.toml
@@ -66,7 +66,7 @@ all = [
 ]
 dev = [
     "hatch",
-    "ruff>=0.3.0",
+    "ruff>=0.5.0",
     "ipython",
     "pytest",
     "pytest-cov",
@@ -307,6 +307,7 @@ ignore = [
     # suppressible-exception
     # https://github.com/vega/altair/pull/3431#discussion_r1629808660
     "SIM105",
+    "PT001",
 ]
 
 # https://docs.astral.sh/ruff/settings/#lint_unfixable

diff --git a/tests/utils/test_compiler.py b/tests/utils/test_compiler.py
@@ -8,7 +8,7 @@
     vlc = None
 
 
-@pytest.fixture()
+@pytest.fixture
 def chart():
     return (
         Chart("cars.json")

diff --git a/tests/utils/test_html.py b/tests/utils/test_html.py
@@ -3,7 +3,7 @@
 from altair.utils.html import spec_to_html
 
 
-@pytest.fixture()
+@pytest.fixture
 def spec():
     return {
         "data": {"url": "data.json"},

diff --git a/tests/utils/test_mimebundle.py b/tests/utils/test_mimebundle.py
@@ -15,7 +15,7 @@
     vf = None
 
 
-@pytest.fixture()
+@pytest.fixture
 def vegalite_spec():
     return {
         "$schema": "https://vega.github.io/schema/vega-lite/v5.json",
@@ -41,7 +41,7 @@ def vegalite_spec():
     }
 
 
-@pytest.fixture()
+@pytest.fixture
 def vega_spec():
     return {
         "$schema": "https://vega.github.io/schema/vega/v5.json",

diff --git a/tests/utils/test_schemapi.py b/tests/utils/test_schemapi.py
@@ -288,7 +288,7 @@ def test_schema_validator_selection():
         Draft6Schema.from_dict(dct)
 
 
-@pytest.fixture()
+@pytest.fixture
 def dct():
     return {
         "a": {"foo": "bar"},

diff --git a/tests/vegalite/test_common.py b/tests/vegalite/test_common.py
@@ -7,7 +7,7 @@
 from altair.vegalite import v5
 
 
-@pytest.fixture()
+@pytest.fixture
 def basic_spec():
     return {
         "data": {"url": "data.csv"},

diff --git a/tests/vegalite/v5/test_data.py b/tests/vegalite/v5/test_data.py
@@ -6,7 +6,7 @@
 from altair.vegalite.v5 import data as alt
 
 
-@pytest.fixture()
+@pytest.fixture
 def sample_data():
     return pd.DataFrame({"x": range(10), "y": range(10)})
 

diff --git a/tests/vegalite/v5/test_renderers.py b/tests/vegalite/v5/test_renderers.py
@@ -19,7 +19,7 @@
     anywidget = None  # type: ignore
 
 
-@pytest.fixture()
+@pytest.fixture
 def chart():
     return alt.Chart("data.csv").mark_point()
 

diff --git a/tests/vegalite/v5/test_theme.py b/tests/vegalite/v5/test_theme.py
@@ -4,7 +4,7 @@
 from altair.vegalite.v5.theme import VEGA_THEMES
 
 
-@pytest.fixture()
+@pytest.fixture
 def chart():
     return alt.Chart("data.csv").mark_bar().encode(x="x:Q")