Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add typings/ to .gitignore #2

Closed
wants to merge 3 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -75,3 +75,6 @@ Untitled*.ipynb

# hatch, doc generation
data.json

# type stubs
typings/
14 changes: 7 additions & 7 deletions RELEASING.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

2. Make certain your branch is in sync with head:

git pull upstream main
git pull origin main

3. Do a clean doc build:

Expand All @@ -25,13 +25,13 @@
5. Commit change and push to main:

git add . -u
git commit -m "chore: bump version to 5.0.0"
git push upstream main
git commit -m "chore: Bump version to 5.0.0"
git push origin main

6. Tag the release:

git tag -a v5.0.0 -m "version 5.0.0 release"
git push upstream v5.0.0
git push origin v5.0.0

7. Build source & wheel distributions:

Expand All @@ -54,11 +54,11 @@
11. Commit change and push to main:

git add . -u
git commit -m "chore: bump version to 5.1.0dev"
git push upstream main
git commit -m "chore: Bump version to 5.1.0dev"
git push origin main

12. Double-check that a conda-forge pull request is generated from the updated
pip package by the conda-forge bot (may take up to ~an hour):
pip package by the conda-forge bot (may take up to several hours):
https://github.com/conda-forge/altair-feedstock/pulls

13. Publish a new release in https://github.com/vega/altair/releases/
2 changes: 1 addition & 1 deletion tests/examples_arguments_syntax/cumulative_count_chart.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,5 +17,5 @@
sort=[{"field": "IMDB_Rating"}],
).mark_area().encode(
x="IMDB_Rating:Q",
y="cumulative_count:Q"
y=alt.Y("cumulative_count:Q", stack=False)
)
21 changes: 21 additions & 0 deletions tests/examples_methods_syntax/cumulative_count_chart.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
"""
Cumulative Count Chart
----------------------
This example shows an area chart with cumulative count.
Adapted from https://vega.github.io/vega-lite/examples/area_cumulative_freq.html

"""
# category: distributions

import altair as alt
from vega_datasets import data

source = data.movies.url

alt.Chart(source).transform_window(
cumulative_count="count()",
sort=[{"field": "IMDB_Rating"}],
).mark_area().encode(
x="IMDB_Rating:Q",
y=alt.Y("cumulative_count:Q").stack(False)
)