Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch finally with noop to propagate error #1928

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Catch finally with noop to propagate error #1928

wants to merge 1 commit into from

Conversation

daviferreira
Copy link

Fixes #1853

@jens-bjerrehuus
Copy link

+1

This also solves a problem we're seeing, where a call to abort() a pending request always results in an unhandled rejection, because the cancelled/aborted http request is considered failed and ends up in the same problematic finally referred to in the linked bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderschneider alexanderschneider alexanderschneider approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daviferreira @jens-bjerrehuus @alexanderschneider