OAK-11525 Update fullGC configuration for audit logging into Mongo collection #1
+109
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joscorbe
suggested changes
Mar 3, 2025
| public static final String GC_COLLECTED_AT = "_gcCollectedAt"; | ||
| private static final Logger LOG = getLogger(MongoFullGcNodeBin.class); |
There was a problem hiding this comment.
Use LoggerFactory.getLogger(MongoFullGcNodeBin.class) instead of getLogger(MongoFullGcNodeBin.class)
reschke
reviewed
Mar 3, 2025
| @@ -112,8 +112,13 @@ public class MongoVersionGCSupport extends VersionGCSupport { | |||
| */ | |||
| private final int batchSize = Integer.getInteger( | |||
Joscorbe
approved these changes
Mar 4, 2025
|
The "into" branch is on your private repository, which I can't access, so can't merge it. You can probably integrate this PR into apache#2038 and everything will be merged together into Oak. |
added 7 commits
March 4, 2025 10:05
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add OSGi configuration to enable/disable full GC audit bin (default disabled)
Add
-fullGCAuditLoggingEnabledoption for oak-run (default disabled)