Fix phpstan issues (#78)

* Update README.md

* Fix: call_user_func expects callable, Closure given

* Fix Closure(mixed) type issues

* Formatting

* Remove phpstan ignore

* Add Lighthouse guard configuration section to README.md

* Fix: call_user_func expects callable, Closure given

* Fix Closure(mixed) type issues

* Formatting

* Remove phpstan ignore

* Max phpstan level without ignoring errors

* normalize composer.json

* Ignore files for dist checkout

* Ignore files for dist checkout

* Update README.md

.gitattributes

@@ -2,10 +2,16 @@
 # https://www.kernel.org/pub/software/scm/git/docs/gitattributes.html
 
 # Ignore all test and documentation with "export-ignore".
-/.gitattributes     export-ignore
-/.gitignore         export-ignore
-/.travis.yml        export-ignore
-/phpunit.xml.dist   export-ignore
-/.scrutinizer.yml   export-ignore
-/tests              export-ignore
-/.editorconfig      export-ignore
+/.gitattributes         export-ignore
+/.gitignore             export-ignore
+/.travis.yml            export-ignore
+/phpunit.xml.dist       export-ignore
+/.scrutinizer.yml       export-ignore
+/tests                  export-ignore
+/.editorconfig          export-ignore
+/stubs                  export-ignore
+/phpstan.neon           export-ignore
+/.php_cs.tests.php      export-ignore
+/.php_cs.common.php     export-ignore
+/.php-cs-fixer.dist.php export-ignore
+/.coveralls.yml         export-ignore

.gitignore

@@ -6,3 +6,4 @@ coverage
 .phpunit.cache
 .php_cs.cache
 .php_cs.tests.cache
+phpunit.xml

README.md

@@ -24,7 +24,7 @@ Add [Laravel Sanctum](https://github.com/laravel/sanctum) support to [Lighthouse
 
 - [laravel/laravel:^9.0](https://github.com/laravel/laravel)
 - [laravel/sanctum:^2.0](https://github.com/laravel/sanctum)
-- [nuwave/lighthouse:^5.5](https://github.com/nuwave/lighthouse)
+- [nuwave/lighthouse:^5.55.1](https://github.com/nuwave/lighthouse)
 
 ## Installation
 

composer.json

@@ -21,7 +21,7 @@
         "php": "^8.0.2",
         "laravel/framework": "^9.0",
         "laravel/sanctum": "^2.14",
-        "nuwave/lighthouse": "^5.5"
+        "nuwave/lighthouse": "^5.55.1"
     },
     "require-dev": {
         "friendsofphp/php-cs-fixer": "^3.0",
@@ -56,6 +56,9 @@
         }
     },
     "scripts": {
+        "post-autoload-dump": [
+            "@php ./vendor/bin/testbench package:discover --ansi"
+        ],
         "analyze": "vendor/phpstan/phpstan/phpstan analyse",
         "check-style": [
             "php-cs-fixer fix --diff --dry-run",

phpstan.neon

@@ -9,8 +9,8 @@ parameters:
   paths:
     - src
     - tests
-  ignoreErrors:
-    -
-      message: '#Parameter \#1 \$(function|callback) of function call_user_func expects callable\(\): mixed, Closure\|null given\.#'
-      path: tests
-    - '#Call to an undefined method Illuminate\\Testing\\TestResponse::assertGraphQLErrorMessage\(\).#'
+  stubFiles:
+    - vendor/nuwave/lighthouse/_ide_helper.php
+    - stubs/Illuminate/Auth/Notifications/ResetPassword.stub
+    - stubs/Illuminate/Auth/Notifications/Notification.stub
+    - stubs/Illuminate/Contracts/Auth/CanResetPassword.stub

src/Services/ResetPasswordService.php

@@ -37,7 +37,6 @@ public function transformUrl(CanResetPassword $notifiable, string $token, string
 
     public function setResetPasswordUrl(string $url): void
     {
-        /** @phpstan-ignore-next-line */
         ResetPasswordNotification::createUrlUsing(function (CanResetPassword $notifiable, string $token) use ($url): string {
             return $this->transformUrl($notifiable, $token, $url);
         });

stubs/Illuminate/Auth/Notifications/Notification.stub

@@ -0,0 +1,7 @@
+<?php
+
+namespace Illuminate\Notifications;
+
+class Notification
+{
+}

stubs/Illuminate/Auth/Notifications/ResetPassword.stub

@@ -0,0 +1,19 @@
+<?php
+
+namespace Illuminate\Auth\Notifications;
+
+use Illuminate\Contracts\Auth\CanResetPassword;
+use Illuminate\Notifications\Notification;
+
+class ResetPassword extends Notification
+{
+    /**
+     * Set a callback that should be used when creating the reset password button URL.
+     *
+     * @param  \Closure(CanResetPassword, string): string  $callback
+     * @return void
+     */
+    public static function createUrlUsing($callback)
+    {
+    }
+}

stubs/Illuminate/Contracts/Auth/CanResetPassword.stub

@@ -0,0 +1,7 @@
+<?php
+
+namespace Illuminate\Contracts\Auth;
+
+interface CanResetPassword
+{
+}

tests/Integration/GraphQL/Mutations/ForgotPasswordTest.php

@@ -45,7 +45,8 @@ public function it_sends_a_reset_password_notification(): void
         ]);
 
         Notification::assertSentTo($user, function (ResetPassword $notification) use ($user) {
-            /** @phpstan-ignore-next-line */
+            static::assertIsCallable($notification::$createUrlCallback);
+
             $url = call_user_func($notification::$createUrlCallback, $user, $notification->token);
 
             return $url === "https://my-front-end.com/[email protected]&token={$notification->token}";

tests/Integration/GraphQL/Mutations/RegisterTest.php

@@ -93,6 +93,8 @@ public function it_sends_an_email_verification_notification(): void
         $user = UserMustVerifyEmail::first();
 
         Notification::assertSentTo($user, function (VerifyEmail $notification) use ($user) {
+            static::assertIsCallable($notification::$createUrlCallback);
+
             $url = call_user_func($notification::$createUrlCallback, $user);
 
             /** @var int|string $id */
@@ -151,6 +153,8 @@ public function it_sends_a_signed_email_verification_notification(): void
         $user = UserMustVerifyEmail::first();
 
         Notification::assertSentTo($user, function (VerifyEmail $notification) use ($user) {
+            static::assertIsCallable($notification::$createUrlCallback);
+
             $url = call_user_func($notification::$createUrlCallback, $user);
 
             /** @var int|string $id */

tests/Integration/GraphQL/Mutations/ResendEmailVerificationTest.php

@@ -50,6 +50,8 @@ public function it_resends_an_email_verification_notification(): void
         static::assertSame('EMAIL_SENT', $response->json('data.resendEmailVerification.status'));
 
         Notification::assertSentTo($user, function (VerifyEmail $notification) use ($user) {
+            static::assertIsCallable($notification::$createUrlCallback);
+
             $url = call_user_func($notification::$createUrlCallback, $user);
 
             $hash = sha1('[email protected]');
@@ -98,6 +100,8 @@ public function it_resends_a_signed_email_verification_notification(): void
         static::assertSame('EMAIL_SENT', $response->json('data.resendEmailVerification.status'));
 
         Notification::assertSentTo($user, function (VerifyEmail $notification) use ($user) {
+            static::assertIsCallable($notification::$createUrlCallback);
+
             $url = call_user_func($notification::$createUrlCallback, $user);
 
             $hash      = sha1('[email protected]');

tests/Integration/Services/EmailVerificationServiceTest.php

@@ -82,6 +82,8 @@ public function it_sets_the_verification_url(): void
 
         $this->service->setVerificationUrl('https://mysite.com/verify-email/__ID__/__HASH__');
 
+        static::assertIsCallable(VerifyEmail::$createUrlCallback);
+
         $url = call_user_func(VerifyEmail::$createUrlCallback, $user);
 
         static::assertSame('https://mysite.com/verify-email/12345/' . sha1('[email protected]'), $url);
@@ -102,6 +104,8 @@ public function it_sets_the_signed_verification_url(): void
 
         $this->service->setVerificationUrl('https://mysite.com/verify-email/__ID__/__HASH__/__EXPIRES__/__SIGNATURE__');
 
+        static::assertIsCallable(VerifyEmail::$createUrlCallback);
+
         $url = call_user_func(VerifyEmail::$createUrlCallback, $user);
 
         $signature = hash_hmac('sha256', serialize([

tests/Integration/Services/ResetPasswordServiceTest.php

@@ -61,7 +61,8 @@ public function it_sets_the_reset_password_url(): void
 
         $this->service->setResetPasswordUrl('https://mysite.com/reset-password/__EMAIL__/__TOKEN__');
 
-        /** @phpstan-ignore-next-line */
+        static::assertIsCallable(ResetPassword::$createUrlCallback);
+
         $url = call_user_func(ResetPassword::$createUrlCallback, $user, $token);
 
         static::assertSame('https://mysite.com/reset-password/[email protected]/token123', $url);