Skip to content
This repository has been archived by the owner on Sep 23, 2024. It is now read-only.

Settings (2) #3

Closed

Conversation

Dacid99
Copy link

@Dacid99 Dacid99 commented Sep 14, 2024

Hi Daniel,

thanks for the great work on this project!

In this pull request I added preferences to manage the BaseURL and the StoreCameraPhotos configuration outside of the BuildConfig. That way this app can be compiled once for all users and each user can set their own instance URL inside the app. This will also allow to publish the app in an appstore.

I have also already added a settingspage where said configuration can be done by the user. As I was not sure how to best connect it to the MainActivity (unfortunately I cannot add another icon to the bottomnavbar as it only supports 5 items) I left this open. If you have a good idea how you would like to realize this, Im happy to implement that as well (as long as it's not too extravagant xD).

(If you like we can also continue this discussion in german, Im from germany too)

Sorry for the duplicate request but I had to do some restructuring in my repo that killed the original one.

@danielbrendel
Copy link
Owner

Hi David, thank you for your PR.

Unfortunately, as stated in #1 (comment) I discontinued the development and support for the native android app in favor of the PWA feature. You can read more details in the linked comment.

Sorry, if that is not the answer you expected. Since this is not the first time this topic comes up, I might just archive this repo. However since the native android app project is MIT licensed you can also use your own fork for your changes. If you want to do that, then in regards of your questions, I usually tend to add native app links in the sticky navbar. You would need to run some JavaScript via the webview URL loading method to accomplish this. This way you can add a link to the navbar and call native android app methods via a JavaScript interface. It's fairly easy.

I will archive this repo in favor of my decision (I only posted this on the discord and mastodon, but fairly aware that doesn't reach everyone).

@Dacid99 Dacid99 deleted the hortusfox-android-pullrequest branch September 27, 2024 18:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants