This repository has been archived by the owner on Sep 23, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Daniel,
thanks for the great work on this project!
In this pull request I added preferences to manage the BaseURL and the StoreCameraPhotos configuration outside of the BuildConfig. That way this app can be compiled once for all users and each user can set their own instance URL inside the app. This will also allow to publish the app in an appstore.
I have also already added a settingspage where said configuration can be done by the user. As I was not sure how to best connect it to the MainActivity (unfortunately I cannot add another icon to the bottomnavbar as it only supports 5 items) I left this open. If you have a good idea how you would like to realize this, Im happy to implement that as well (as long as it's not too extravagant xD).
(If you like we can also continue this discussion in german, Im from germany too)
Sorry for the duplicate request but I had to do some restructuring in my repo that killed the original one.