Merge pull request #65 from danieldelcore/fix-object-parsing

🐛 Fixes object style parsing with numbers
danieldelcore · May 25, 2020 · b58d88f · b58d88f
2 parents 6cb9544 + c2853fb
commit b58d88f
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 1 deletion.
diff --git a/.changeset/loud-clocks-peel.md b/.changeset/loud-clocks-peel.md
@@ -0,0 +1,5 @@
+---
+'@trousers/parser': patch
+---
+
+Object styles containing mixed value types (string/number) will now be parsed correectly
diff --git a/packages/parser/src/parse-object.spec.ts b/packages/parser/src/parse-object.spec.ts
@@ -13,6 +13,15 @@ describe('parseObject', () => {
         );
     });
 
+    it('correctly converts a mixed-unit style object', () => {
+        const result = parseObject({
+            width: '2px',
+            height: 0,
+        });
+
+        expect(result).toEqual('width: 2px;\nheight: 0;');
+    });
+
     it('correctly converts style object with a nested selector', () => {
         const result = parseObject({
             ':hover': {

diff --git a/packages/parser/src/parse-object.ts b/packages/parser/src/parse-object.ts
@@ -11,7 +11,8 @@ const parseObject = (
 ): string =>
     Object.keys(styleObj)
         .map(property =>
-            typeof styleObj[property] === 'string'
+            typeof styleObj[property] === 'string' ||
+            typeof styleObj[property] === 'number'
                 ? `${parser(property)}: ${styleObj[property]};`
                 : `${parser(property)} {\n${parseObject(
                       styleObj[property],