feat: add support to string in includes #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request @alisonrag, I'll be reviewing your commits these days to include them in the codebase. |
danielduarte
requested changes
Sep 18, 2024
| @@ -143,7 +143,7 @@ const evalLiteral = node => { | |||
| assert.strictEqual(node.type, NODE_LITERAL); | |||
|
|
|||
| const { value } = node; | |||
| const typeNames = [TYPE_NUMBER, TYPE_BOOLEAN, TYPE_STRING]; | |||
| const typeNames = [TYPE_NUMBER, TYPE_BOOLEAN, TYPE_STRING, TYPE_OBJECT]; | |||
There was a problem hiding this comment.
Please remove TYPE_OBJECT from typeNames since it would be an error if a node of type NODE_LITERAL has an object as value.
| }, | ||
| matchAll: (target, context, options, runState) => { | ||
| const pattern = context.get('pattern'); | ||
| return target.match(pattern); |
There was a problem hiding this comment.
Please call matchAll instead.
| return target.replace( | ||
| searchValue, | ||
| newValue instanceof AbstractFunction ? | ||
| (x) => newValue.exec(x, context, options, runState) : |
There was a problem hiding this comment.
exec method requires the first argument to be an array of parameters. Please fix the code to pass in all the arguments to the replacer function.
| return target.replaceAll( | ||
| searchValue, | ||
| newValue instanceof AbstractFunction ? | ||
| (x) => newValue.exec(x, context, options, runState) : |
There was a problem hiding this comment.
exec method requires the first argument to be an array of parameters. Please fix the code to pass in all the arguments to the replacer function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.