chore: fixed code smells

.github/workflows/ci.yml

@@ -16,7 +16,7 @@ jobs:
     strategy:
       matrix:
         # See supported Node.js release schedule at https://nodejs.org/en/about/releases/
-        node-version: [12.x, 14.x, 16.x, 17.x, 18.x]
+        node-version: [12.x, 14.x, 16.x, 18.x]
 
     steps:
     - uses: actions/checkout@v2

src/engine/flow-manager.ts

@@ -100,8 +100,8 @@ export class FlowManager {
           let error;
           if (statusCode !== 200) {
             error = new Error(`Request failed with status code: ${statusCode}`);
-          } else if (!(/^application\/json/.test(contentType) || /^text\/plain/.test(contentType))) {
-            error = new Error(`Invalid content-type. Expected application/json or text/plain but received ${contentType}`);
+          } else if (!(contentType.startsWith('application/json') || contentType.startsWith('text/plain'))) {
+            error = new Error(`Invalid content-type: Expected 'application/json' or 'text/plain' but received '${contentType}'`);
           }
 
           if (error) {

src/engine/flow-state/flow-state.ts

@@ -345,7 +345,9 @@ export abstract class FlowState implements IFlow {
     this.runStatus.state.postProcessFinished(error, stopFlowExecutionOnError);
   }
 
-  protected postProcessFinished(_error: Error | boolean, _stopFlowExecutionOnError: boolean): void {}
+  protected postProcessFinished(_error: Error | boolean, _stopFlowExecutionOnError: boolean): void {
+    // Default empty implementation to be overridden when applies.
+  }
 
   protected createTransitionError(transition: string): Error {
     return new Error(`Cannot execute transition ${transition} in current state ${this.getStateCode()}.`);

src/engine/task-process.ts

@@ -38,7 +38,7 @@ export class TaskProcess {
 
     let resolverFn = this.taskResolverExecutor as TaskResolverFn;
     let resolverThis: TaskResolverClass | undefined = undefined;
-    const isClassResolver = this.taskResolverExecutor.prototype && this.taskResolverExecutor.prototype.exec;
+    const isClassResolver = this.taskResolverExecutor.prototype?.exec;
     if (isClassResolver) {
       // @todo try to remove type casts in this code section
       const resolverInstance = new (this.taskResolverExecutor as TaskResolverClass)();
@@ -68,7 +68,7 @@ export class TaskProcess {
       // @sonar end-ignore
 
       const resultIsObject = typeof resolverResult === 'object';
-      const resultIsPromise = resolverResult && resolverResult.constructor && resolverResult.constructor.name === 'Promise';
+      const resultIsPromise = resolverResult?.constructor?.name === 'Promise';
 
       if (!resultIsObject) {
         throw new Error(

src/engine/task.ts

@@ -81,26 +81,19 @@ export class Task {
     for (const [resolverParamName, paramSolvingInfo] of Object.entries(resolverParams)) {
       // @todo Add test to check the case when a loop round does not set anything and make sure next value (`paramValue`) is undefined by default
 
-      // If it is string, it is a task param name
       if (typeof paramSolvingInfo === 'string') {
-        const taskParamName = paramSolvingInfo;
-        paramValue = solvedReqs[taskParamName];
-      }
-
-      // If it is an object, expect the format { [value: <some value>], [transform: <some template>] }
-      else {
-        // Implicit case: if (typeof paramSolvingInfo === 'object' && paramSolvingInfo !== null)
+        // If it is string, it is a task param name
+        paramValue = solvedReqs[paramSolvingInfo];
+      } else if (Object.prototype.hasOwnProperty.call(paramSolvingInfo, 'value')) {
+        // If it is an object, expect the format { value: <some value> } or { transform: <some template> }
+        // Implicit condition: typeof paramSolvingInfo === 'object' && paramSolvingInfo !== null
         // Direct value pre-processor
-        if (Object.prototype.hasOwnProperty.call(paramSolvingInfo, 'value')) {
-          paramValue = (paramSolvingInfo as ResolverParamInfoValue).value;
-        }
-
+        paramValue = (paramSolvingInfo as ResolverParamInfoValue).value;
+      } else {
         // Template transform pre-processor
-        else {
-          // Implicit case: if (paramSolvingInfo.hasOwnProperty('transform'))
-          const template = (paramSolvingInfo as ResolverParamInfoTransform).transform;
-          paramValue = ST.select(solvedReqs).transformWith(template).root();
-        }
+        // Implicit condition: paramSolvingInfo.hasOwnProperty('transform')
+        const template = (paramSolvingInfo as ResolverParamInfoTransform).transform;
+        paramValue = ST.select(solvedReqs).transformWith(template).root();
       }
 
       params[resolverParamName] = paramValue;
@@ -120,7 +113,7 @@ export class Task {
 
     const results: ValueMap = {};
 
-    let resolverResults = (this.spec.resolver ?? {}).results ?? {};
+    let resolverResults = this.spec.resolver?.results ?? {};
 
     if (automap) {
       const provides = this.spec.provides ?? [];

test/load-from-url.ts

@@ -83,7 +83,7 @@ describe('can run a flow', function () {
       throw new Error('An error should have been thrown');
     } catch (err) {
       expect((err as Error).message).to.be.eql(
-        'Invalid content-type. Expected application/json or text/plain but received some-unknown/content-format',
+        "Invalid content-type: Expected 'application/json' or 'text/plain' but received 'some-unknown/content-format'",
       );
     }
   });