Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not panic when encountering external schemas #729

Merged
merged 1 commit into from
Feb 16, 2025

Conversation

danielgtaylor
Copy link
Owner

This PR ensures the schema link transformer only runs when the ref is a valid intra-document (local) ref and not an external one. External ones are ignored.

Fixes #703.

@Copilot Copilot bot review requested due to automatic review settings February 16, 2025 06:43

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Copy link

codecov bot commented Feb 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.78%. Comparing base (169da69) to head (227f5fc).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #729   +/-   ##
=======================================
  Coverage   92.78%   92.78%           
=======================================
  Files          22       22           
  Lines        5062     5062           
=======================================
  Hits         4697     4697           
  Misses        314      314           
  Partials       51       51           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielgtaylor danielgtaylor merged commit ba4ad0f into main Feb 16, 2025
7 checks passed
@danielgtaylor danielgtaylor deleted the external-schema branch February 16, 2025 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panic when attempting to refer to an external schema
1 participant