Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add example for type renaming #731

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

shakhzodkudratov
Copy link
Contributor

I faced #649 #670 like issues when I have internal User struct and conflicting recursive github.User through github.Repository. Added an example for workaround.

Copy link
Owner

@danielgtaylor danielgtaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great example thank you!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • examples/go.mod: Language not supported
Comments suppressed due to low confidence (1)

examples/renaming-type/main.go:48

  • [nitpick] The struct name 'GitHubUser' is inconsistent with the naming convention used in the rest of the code. It should be renamed to 'GithubUser'.
type GitHubUser struct {
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.78%. Comparing base (ba4ad0f) to head (01cccec).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #731   +/-   ##
=======================================
  Coverage   92.78%   92.78%           
=======================================
  Files          22       22           
  Lines        5062     5062           
=======================================
  Hits         4697     4697           
  Misses        314      314           
  Partials       51       51           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielgtaylor danielgtaylor merged commit 7cd0fd6 into danielgtaylor:main Feb 18, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants