Add a synchronous grpc client #647
Conversation
| @@ -160,9 +227,9 @@ class {{ service.py_name }}Base(ServiceBase): | |||
| , {{ method.py_input_message_param }}: "{{ method.py_input_message_type }}" | |||
| {%- else -%} | |||
| {# Client streaming: need a request iterator instead #} | |||
| , {{ method.py_input_message_param }}_iterator: {{ output_file.typing_compiler.async_iterator(method.py_input_message_type) }} | |||
| , {{ method.py_input_message_param }}_iterator: "{{ output_file.typing_compiler.async_iterator(method.py_input_message_type) }}" | |||
There was a problem hiding this comment.
This and the next diff are in fact fixes for the existing stub generation. If wanted I could split it into a separate PR.
| we are going to mock the channel and simply test the client. | ||
|
|
||
| If we wanted to test without mocking we would need to use all the machinery here: | ||
| https://github.com/grpc/grpc/blob/master/src/python/grpcio_tests/tests/testing/_client_test.py |
There was a problem hiding this comment.
Or I could spawn an actual server. I would think that's the best testing, but it is not done so in the rest of the code (which uses the nice grpclib ChannelFor)
| DoThingResponse, | ||
| GetThingRequest, | ||
| GetThingResponse, | ||
| TestSyncStub as ThingServiceClient, |
There was a problem hiding this comment.
This is the new synchronous stub.
|
Hello, and thank you for the work! I agree that it would be a great idea to support this. However, I wouldn't merge the PR as it is now: indeed, I would say that adding an option to allow the user to choose between sync and async right at the beginning would be better. Plus, it should be possible to avoid duplicating all the template code. Then, this should be integrated in the github action so that these implementations are tested too... So it is not a small change. However, before starting working on that, I would like first to simplify the current implementation, since it will have an impact on the template file. |
Summary
I find that often, we want a non async grpc client. This PR adds a
*SyncStubgenerated class using only the standard synchronous grpc library. It is pretty much exactly the same as the*Stubone except it is synchronous.I have not tested it extensively yet, but the code is pretty straightforward.
Let me know what you think and I can tweak/test more. Also you might not want something like this or would want it to be an option/extra instead of always generating it.
Checklist