🐛 Fix correctTerm breaking hyphenated terms #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bug is caused by the `correctTerm` function in the TitleCaserUtils class. It uses `delimiters.source.charAt(0)` to join the parts after splitting the word. When using the default delimiter regex `/[-']/`, `delimiters.source.charAt(0)` returns `"["` instead of the expected hyphen or apostrophe. The solution was to determine the correct joiner based on whether the original word includes a hyphen or an apostrophe. This change has been applied in the updated minified code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug is caused by the
correctTermfunction in the TitleCaserUtils class. It usesdelimiters.source.charAt(0)to join the parts after splitting the word. When using the default delimiter regex/[-']/,delimiters.source.charAt(0)returns"["instead of the expected hyphen or apostrophe. The solution was to determine the correct joiner based on whether the original word includes a hyphen or an apostrophe. This change has been applied in the updated minified code.Before the fix,
e-commerceresulted inE[commerceCloses #9