fix unsafe uintptr usage to be GC-safe on go1.25

[thaJeztah]

• relates to update to go1.25.1 docker/docker-credential-helpers#387

Replace uintptr fields with typed pointers so the GC considers them alive.

relates to changes in go1.25: https://go.dev/doc/go1.25#faster-slices

Faster slices

The compiler can now allocate the backing store for slices on the stack
in more situations, which improves performance. This change has the potential
to amplify the effects of incorrect unsafe.Pointer usage, see for example
issue 73199. In order to track down these problems, the bisect tool can
be used to find the allocation causing trouble using the -compile=variablemake
flag. All such new stack allocations can also be turned off using
-gcflags=all=-d=variablemakehash=n.

Assisted-by: OpenAI ChatGPT

[thaJeztah]

@danieljoos PTAL; this fixes a bug that's exposed in go1.25 where the GC purges the structure during write;

see;

• update to go1.25.1 docker/docker-credential-helpers#387

Regression-test is ran on this PR with go1.25;

• [testing] gha: update go matrix; add go1.23, stable and oldstable thaJeztah/wincred#1
• (same branch as gha: update go matrix; add go1.23, stable and oldstable #77)

[thaJeztah]

A colleague (@akerouanton) suggested to try if just the runtime.KeepAlive(ncred) would already be enough; will give that a spin as well.

[thaJeztah]

A colleague (@akerouanton) suggested to try if just the runtime.KeepAlive(ncred) would already be enough; will give that a spin as well.

Gave that a try in thaJeztah#1, but doesn't look to be enough; still failing if we only add that.

Looks to be documented indeed that that's the case; https://pkg.go.dev/unsafe#Pointer

A uintptr is an integer, not a reference. Converting a Pointer to a uintptr creates an integer value with no pointer semantics. Even if a uintptr holds the address of some object, the garbage collector will not update that uintptr's value if the object moves, nor will that uintptr keep the object from being reclaimed.

[akerouanton]

LGTM

[danieljoos]

Very nice, thank you for this change!
Would you mind rebasing or merge master into this such that the tests for stable and oldstable run once with your new test case?

[thaJeztah]

For sure; rebased!

Also apologies if you got pinged on your Slack; I happened to be chatting with a colleague of you when I noticed you're GitHub staff, so thought I'd abuse the opportunity (I know I always overlook my personal projects during the week, so thought it's worth a try) ❤️

Definitely owe you a 🍻 or other beverage if we happen to meet in person!

[danieljoos]

No problem at all. Didn't have a look into my private repos for a while and probably wouldn't have noticed in time.

Thank you for this very valuable change!

[thaJeztah]

Whoop, thank you!