Refactor: remove old code, change layout, simplify #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The middleware.go file in the server package was deleted. The server and routes.go have also been updated with minor adjustments and a couple of new static paths being logged. In the configuration, some environment variables were adjusted, mainly changing the "AllowedOrigins" to "Domain". Finally, corresponding changes have been made in the ".env.example" and "helpers.go" files to reflect the new domain configuration.
… # are not escaped in environment variables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a refresh of the codebase.
I have learnt a lot since first implementing this project.
The layout better reflects lessons learned over time. Much of the logic is unchanged and needs additional refactoring but works as is. Old, unused code has been deleted. Litestream logic and configuration updated to match current recommendations.