Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add userspace port CLI option #451

Merged
merged 2 commits into from
Aug 20, 2024
Merged

Conversation

shamanec
Copy link
Sponsor Collaborator

@shamanec shamanec commented Aug 8, 2024

  • When trying to run a command while manually supplying rsd-port and address and using userspace tunnels, also the userspace tunnel port has to be supplied or it doesn't work

* When trying to run a command while manually supplying `rsd-port` and `address` and using userspace tunnels, also the userspace tunnel port has to be supplied or it doesn't work
@danielpaulus
Copy link
Owner

@dmissmann can you take a look?

Copy link
Collaborator

@dmissmann dmissmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if I understand why there can be a problem. When rsd-port and address are provided we are pointing to a tunnel that is not a userspace tunnel (for example I usually use it when I want to connect to the tunnel that is opened by MacOS). Why should there be a userspace tunnel at the same time?

@shamanec
Copy link
Sponsor Collaborator Author

Not sure if I understand why there can be a problem. When rsd-port and address are provided we are pointing to a tunnel that is not a userspace tunnel (for example I usually use it when I want to connect to the tunnel that is opened by MacOS). Why should there be a userspace tunnel at the same time?

My use case was that I needed finer control over tunnels so I was starting a tunnel per device using the module but then I wanted to run a command using the CLI providing rsd-port and address - but it doesn't work if the tunnel is a userspace tunnel. In the end I resolved it by using the modules everywhere around my app instead of using the CLI so I don't much care now if this gets merged. It might be good if someone wants finer control or is testing something out

@dmissmann
Copy link
Collaborator

Not sure if I understand why there can be a problem. When rsd-port and address are provided we are pointing to a tunnel that is not a userspace tunnel (for example I usually use it when I want to connect to the tunnel that is opened by MacOS). Why should there be a userspace tunnel at the same time?

My use case was that I needed finer control over tunnels so I was starting a tunnel per device using the module but then I wanted to run a command using the CLI providing rsd-port and address - but it doesn't work if the tunnel is a userspace tunnel. In the end I resolved it by using the modules everywhere around my app instead of using the CLI so I don't much care now if this gets merged. It might be good if someone wants finer control or is testing something out

ah ok, got it. and since it's an optional parameter it's perfectly fine 👍

@danielpaulus
Copy link
Owner

LGTM, Thanks Nikola :-D

@danielpaulus danielpaulus merged commit 4ba4207 into main Aug 20, 2024
5 checks passed
@danielpaulus danielpaulus deleted the fix-device-rsd-provider-userspace branch August 20, 2024 21:23
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants