Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid panic due to interface conversion without check #457

Merged
merged 2 commits into from
Aug 19, 2024
Merged

Avoid panic due to interface conversion without check #457

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d3a188f
fix: avoid panic due to interface conversion without check
nicolasbouffard May 29, 2024
e36b143
Merge branch 'main' into fix-panic-interface-conversion
danielpaulus Aug 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion ios/tunnel/untrusted.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,14 @@ func (t *tunnelService) createTunnelListener() (tunnelListener, error) {
return tunnelListener{}, err
}
port := createListener["port"].(float64)
devPublicKey := createListener["devicePublicKey"].(string)
devPublicKeyRaw, found := createListener["devicePublicKey"]
if !found {
return tunnelListener{}, fmt.Errorf("no public key found")
}
devPublicKey, isString := devPublicKeyRaw.(string)
if !isString {
return tunnelListener{}, fmt.Errorf("public key is not a string")
}
devPK, err := base64.StdEncoding.DecodeString(devPublicKey)
if err != nil {
return tunnelListener{}, err
Expand Down
Loading