-
-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Support for XCTest #464
Add Support for XCTest #464
Conversation
I think the big question for me is if we can detect that a file is a XCTest or a XCUiTest and automatically set this flag, or if we should leave this decision to clients. We tried to detect this by looking at the file extension, but this does not seem to work. |
@bahrimootaz this looks really nice, merging the other PRs has created a small conflict. Can you please resolve it? |
it can be detected when you have access to the |
# Conflicts: # main.go
I rebased master and resolved the conflict. Can you please take a look again. |
After Checking a lot of Docs I think it's safe to say: Accessing the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -74,7 +74,6 @@ Usage: | |||
ios info [display | lockdown] [options] | |||
ios image list [options] | |||
ios image mount [--path=<imagepath>] [options] | |||
ios image unmount [options] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems this has been removed by mistake 😢
--xctest
toios runtest
by the default, if the flag
--xctest
is not provided we will run XCUITEST. so to be able to run an XCTEST we need the flag to be present.