-
-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial Support for .xctestrun File Format Version 2 #559
base: main
Are you sure you want to change the base?
Conversation
Polish code for iterating over configs
…nt doesn't require a BundleId.
This reverts commit d94ca21.
…tions on missing or multiple TestConfigurations. Only one TestConfigurations is expected
var results []TestSuite | ||
for _, target := range xcTestTargets { | ||
suites, err := RunTestWithConfig(ctx, target) | ||
if err != nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this would effectivelly stop test executions if one has an error. I don't know if that's a good idea.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we have tests that are erroring => no it won't stop execution of other tests if exists.
but if the failure because of something we do in the testmanagerd, it will stop execution => which is expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if there are two test targets and the first one returns an error here it won't execute the second one. So it would stop the execution.
I guess we can return both, the partial results and the error
var results []TestSuite
var targetErrors []error
for _, target := range xcTestTargets {
suites, err := RunTestWithConfig(ctx, target)
if err != nil {
targetErrors = append(targetErrors, err)
continue
}
...
}
return results, errors.join(targetErrors...)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dmissmann nice idea, we implemented this
Co-authored-by: Simon Schaefer <[email protected]>
Co-authored-by: Simon Schaefer <[email protected]>
Remove unneeded xcuitest change
Skip XCUITest when running xctestrun files
Reset Testlistener at correct place
Refactor xctestrunutils test
Description :
Enable the execution of XCTest cases using
.xctestrun
configuration files in version 2 format, expanding compatibility and aligning with latest Xcode standards.Context :
Currently, go-ios supports .xctestrun files with format version 1. However, Xcode has introduced version 2 of the
.xctestrun
file format, which brings structural changes and enhancements. To maintain compatibility with modern XCTest setups and improve usability for customers, we need to support this newer format.Reference: new structure of the
.xctestrun
is documented hereTesting :
In this MR we test did test the following scenarios :