Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Three fixes see details in description #102

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Three fixes see details in description #102

wants to merge 4 commits into from

Conversation

jeremydumais
Copy link

  • Integrated the pull request Added defaultOptions to Multi Select List #86 of KoalaBear
  • Fix: If a search value existed, it was not reloaded in the search box when the list was displayed.
  • Fix: Default options were not registered when using a useEffect. The firstRender was happening before.
  • Fix: When using the save mode 'key' and setting values as default options, the component didn't set selected keys correctly.

@bohnerjosh
Copy link

As KoalaBear mentioned, I saw that MultipleSelectList has a defaultOptions property, but it is not implemented. I am working on an app right now where this functionality would be very helpful. Please get this reviewed and merge soon. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeremydumais @bohnerjosh