defaultOption Support for multiple selection #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi thanks for the commiting. What happends if my default is async? Waiting my API call to retrieve my default values. Renders empty array at the start because my state is empty at the start |
|
On your scenario , the code should have work as expected because the defaultOption variable set as any[] . You can also render whole component based on ur async API call result with conditional rendering. |
Gugarauj07
approved these changes
Nov 22, 2023
|
I need to use defaultOptions on multipleSelect, please accpet this pull request asap!!! |
|
Please merge this fix into the library |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was using MultipleSelection in my react-native project , defaultOption props was not work , I have tried to add defaultSelected prop inside of this library . I also tested myself and it seems working ok for now you can also test it by yourself.